feat(updates): add View changelog button to settings#3040
Merged
Conversation
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "add view changelog button to update sett..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There was no way to view the release changelog from Settings. The "What's New" changelog (full release history) was only reachable from the project switcher menu, so a user looking at their current version in Settings → Updates had no path to see what changed.
Changes
Added a View changelog button to the left of the current-version badge in Settings → Updates. It opens the existing
WhatsNewModal(release history grouped by day/week, with "Latest" and "Current" badges marking the version you're on).useWhatsNewStore.getState().open()pattern already used byProjectSwitcher's "View changelog" menu item, so behavior is consistent.WhatsNewModalis already mounted on the settings route, so no extra wiring was needed.ButtonandFlexwere already imported inUpdatesSettings.tsx; only theuseWhatsNewStoreimport was added.How did you test this?
pnpm typecheck(full monorepo, via the pre-commit hook) — passedpnpm --filter @posthog/ui typecheck— passedbiome checkon the changed file (via the pre-commit hook) — passedNo screenshot attached: this worktree can't launch the packaged Electron app, so I couldn't capture the running UI. The change is a small ghost-style View changelog button placed to the left of the existing current-version badge in Settings → Updates; clicking it opens the already-built What's New modal (release history grouped by day/week). No new modal or layout was introduced.
Automatic notifications